Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226425 --- Comment #13 from Lukáš Nykrýn <lnykryn@xxxxxxxxxx> 2011-08-31 10:12:58 EDT --- Checked git version: f8419589a083775a5c3d481237dcc5e8ccd9ddab sox-14.3.2-1 YES source files match upstream YES package meets naming and versioning guidelines. YES specfile is properly named, is cleanly written and uses macros consistently YES dist tag is present INFO clean section and buildroot present clean section is not necessary any more and buildroot is ignored - they should be removed YES license field matches the actual license YES license is open source-compatible NO license text included in package there is mention in COPYING file, that licences are in the files LICENSE.GPL and LICENSE.LGPL, but both are missing in package YES latest version is being packaged YES BuildRequires are proper YES compiler flags are appropriate YES package builds in mock (Rawhide/x86_64) YES debuginfo package looks complete NO rpmlint is silent sox.src: W: spelling-error %description -l en_US eXchange -> exchange, exchanges, exchanged sox.x86_64: W: spelling-error %description -l en_US eXchange -> exchange, exchanges, exchanged these two are OK sox.x86_64: W: shared-lib-calls-exit /usr/lib64/libsox.so.1.0.0 exit@GLIBC_2.2.5 sox-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/sox-14.3.2/src/ladspa.h 4 packages and 0 specfiles checked; 1 errors, 3 warnings YES final provides and requires look sane N/A %check is present and all tests pass YES no shared libraries are added to the regular linker search paths YES owns the directories it creates YES doesn't own any directories it shouldn't YES no duplicates in %files YES scriptlets must be sane YES code, not content N/A large documentation files must go in a -doc subpackage YES %docs are not necessary for the proper functioning of the package YES no headers YES no pkgconfig files YES no libtool .la droppings YES not a GUI app -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review