[Bug 734275] Review Request: aqemu - A QT graphical interface to QEMU and KVM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=734275

--- Comment #7 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-08-30 08:35:08 EDT ---
(In reply to comment #6)
> This is a bit odd as it was still building for me on F15, but makes sense
> nonetheless. Updated.

Did you try to build the package with mock [1]? The mock build failed as you
can see here: http://koji.fedoraproject.org/koji/taskinfo?taskID=3310708

Your latest package builds properly:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3310977


There are a few further things to address:

- desktop-file-validate reports to issues:

/usr/share/applications/aqemu.desktop: warning: key "Encoding" in group
"Desktop Entry" is deprecated
/usr/share/applications/aqemu.desktop: error: (will be fatal in the future):
value "aqemu.png" for key "Icon" in group "Desktop Entry" is an icon name with
an extension, but there should be no extension as described in the Icon Theme
Specification if the value is not an absolute path

=> drop the Encoding entry and remove the .png suffix from aqemu.png (in the
.desktop file).

- you can remove the slash from %{buildroot}/%{_datadir} because %{_datadir} is
an absolute path (usually /usr/share).

- also quote %cmake in the %changelog to make rpmlint happy


[1] http://fedoraproject.org/wiki/Using_Mock_to_test_package_builds

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]