Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=734275 --- Comment #3 from Stephen Gordon <sgordon@xxxxxxxxxx> 2011-08-29 22:00:14 EDT --- Spec URL: http://sgordon.fedorapeople.org/repo/SOURCES/aqemu.spec SRPM URL: http://sgordon.fedorapeople.org/repo/SRPMS/aqemu-0.8.2-2.fc15.src.rpm Thanks for your comments Richard, responding inline to confirm action on each item. (In reply to comment #2) > 1. Your Souce: tag should be the full URL whenever possible. There's a specific > guideline[1] for SourceForge. Updated. > 2. You don't need the "BuildRoot:", "%clean", or "defattr" in "%files" if > you're not going to build for EL5 (Redhat, CentOS, Scientific Linux). I can't > quite remember at what specific release those became unnecessary, but if you're > only building for F14+/EL6+ they're all safe to remove. Updated, was originally considering building for EL5 but seems unlikely now. > 3. I don't recall any rule for it, but unless it's needed for successful > building, I wouldn't do any file manipulation in %prep. Updated, moved to %install. > 4. Speaking of building, Fedora has a cmake macro, "%cmake", that takes care of > the most common configuration options. In your case, you would replace the > whole line with just "%cmake" Updated. > Also, unless it creates a problem, smp flags should be set on make to speed up > building: > > make %{?_smp_mflags} > Updated. > 5. You should never strip the binaries. That would make the debuginfo > sub-package useless. Rpmbuild will take care of that for you. Updated, including the change to specify DESTDIR. Note that this results in the following additional warning from rpmlint: aqemu.x86_64: W: unstripped-binary-or-object /usr/bin/aqemu The resultant binary does however still appear to be executable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review