Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708711 --- Comment #10 from Volker Fröhlich <volker27@xxxxxx> 2011-08-29 17:58:45 EDT --- I don't seem to get the program working with Youtube on Fedora 15. error: /usr/share/quvi/lua/website/youtube.lua:114: no match: fmt_url_map --> https://bugzilla.redhat.com/show_bug.cgi?id=728646 Looks like the 2.16.1 doesn't work either: "Expected Perl-style regular expression, e.g. /pattern/flags" Concerning %config(noreplace): I don't know NomNom, but I don't consider using noreplace a disadvantage. If the user made a change in that case, the old configuration stays in place and the new configuration is saved as .rpmnew. http://fedoraproject.org/wiki/Packaging:Guidelines#Configuration_files Do you think keeping the old version's configuration might stop the new package's version from working? You can also include a copy of the configuration file as an additional source, instead of specifying it line by line in the spec file. A more elegant way to do it, if you want to keep it in the spec for some reason: cat > file_to_write_to <<EOF your text and even more text EOF Two remarks: - It is common to leave a line blank between changelog entries, like so: * Sat Aug 27 2011 Nicoleau Fabien <nicoleau.fabien@xxxxxxxxx> 0.1.4-2 - License fix - Remove unnecessary commands - Handle locales properly * Fri Jun 24 2011 Nicoleau Fabien <nicoleau.fabien@xxxxxxxxx> 0.1.4-1 - "Remove unnecessary commands" is pretty generic and nobody reading only the changelog can guess what changed. Please be more specific! >From a packaging point of view, nothing is blocking the package. I'll make the formal review after we've sorted out, whether it is a quvi or NomNom problem. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review