Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: aqbanking - A library for online banking functions and financial data import/export https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222522 ------- Additional Comments From notting@xxxxxxxxxx 2007-01-15 11:54 EST ------- (In reply to comment #1) > * %defattr missing in several sub-packages Gack, fixed. > * Obsoletes ought to specify max.versions (using "LT", or "LE" > inequations) They're obsolete upstream projects that this replaced - is there really a need to specify a version for such things? > * main package must not own %{_libdir}/gwenhywfar since that belongs > into the "gwenhywfar" pkg already Fixed. > You exclude everything in > %{_libdir}/aqbanking/plugins/*/frontends/* > but only > %{_libdir}/aqbanking/plugins/*/frontends/qbanking > is included explicitly. Other content below > %{_libdir}/aqbanking/plugins/*/frontends/ > would be skipped/excluded silently. So, other frontends could eventually add code. If I only exclude the specific frontend, the code will end up wrongly in the main package. If exclude all, as it's currently done, it will end up silently dropped. Fun. I suppose in the wrong package is better than silently missed. > * the -devel packages ought to "Requires: automake", so the > %{_datadir}/aclocal/ directory is not orphaned - and because smart > applications use automake anyway - it's kinda difficult to determine > the config values without using the foo-config scripts/pkgconfig/automake ??? Why bring automake into the buildroot if the package never calls it? Seems better to have something else own the dir. > * [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT > Useless check. Nowadays buildroot cannot be "/" anymore. Fixed. > * "Requires: pkgconfig" in the frontends' -devel packages is redundant, > since they all need aqbanking-devel which in turn requires pkgconfig > for all its *-config queries (due to the applied Patch2) True, but since all the -config scripts *explicitly* call it, I'm more comfortable leaving the Requires: in. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review