Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731219 --- Comment #12 from Nathan Owe <ndowens04@xxxxxxxxx> 2011-08-26 21:17:19 EDT --- First off, the macros needs to be used consistently, so for example, if you are going to use %{name}, it needs to be used everywhere pipebench is used at, except of course Name: pipebench :). Also noticed that during mkdir for man dir: mkdir -m 755 -p %{buildroot}%{_mandir}/man1 I would specify that the man dir needs to have executive permission, so I would just do: mkdir -p %{buildroot}%{_mandir}/man1 Also there is no need of the Group tag any more, though also doesn't say it must be removed, but in the wiki it says there is no use for it any more. Also when I ran rpmlint on the SPEC file and SRPM, it gave a error with the Source0: and I found out it the Source listed needs to be http://www.habets.pp.se/synscan/files/%{name}-%{version}.tar.gz or w/o macro, whichever way chosen. And of course changelog and revision needs to be +1 Sorry, didn't notice these earlier. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review