Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732200 --- Comment #9 from Martin Stransky <stransky@xxxxxxxxxx> 2011-08-26 15:51:00 EDT --- Thanks for the review and updated spec file! > 2. I could not get the package to build because it was failing to find some > headers. I had to add the following: > > # Fix header references > sed -i "s/menu.h/Menu.h/g" src/kofola/Menu.cpp > sed -i "s/menu.h/Menu.h/g" src/kofola/game_main.cpp > sed -i "s/menu.h/Menu2.h/g" src/kofola/Menu2.cpp > > I'm not sure how you got it to build without this. Perhaps you're not using gcc > 4.6 and in previous versions this was only a warning? You're right, I'm using gcc-4.5 on F14. > 4. This package has a manual requires for berusky2-data. From your sourceforge > link it appears that the data source is separate for a good reason? Yes, the data tar ball is 300MB big and stable. It's the original game data so there's no need to change it. > I noticed that it has a version of 0.4 while this has a version of 0.3. Are > they intended to revise separately? Yes, they're independent. The game binary version is going to upgrade rapidly :) > If so we should probably cover the review request for the data package here as > well. Yes, I submitted both to one bug (this). > I would usually leave the updates to be made by the requester as it's a good > way to learn but there are so many changes I'll attach my updated spec file for > you to review. Thanks a lot, looks okay to me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review