Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710905 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #11 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2011-08-26 08:34:18 EDT --- Build flags are now shown, and they are correct. Other issues have been adressed as well, so this package is APPROVED Since the license is a bit complicated, it wouldn't hurt having a comment such as #C++ files are GPLv2+, .m files are GPLv2+ and GPLv3+, documentation is GFDL Before you build, please make sure that octave-3.4.2-2.fc1{5,6} is present in the buildroot. The update is still in updates-testing, and for some reason the override drops out every once in a while. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review