Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=733603 Peter Robinson <pbrobinson@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |pbrobinson@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |pbrobinson@xxxxxxxxx --- Comment #1 from Peter Robinson <pbrobinson@xxxxxxxxx> 2011-08-26 06:48:46 EDT --- Looks mostly OK. I'll do a full review shortly. A few points to update the package for the latest package standard: 1) Remove BuildRoot: its no longer needed 2) Remove the "rm -rf $RPM_BUILD_ROOT" line from install 3) Remove %clean section %clean rm -rf $RPM_BUILD_ROOT 4) Description needs to wrap line at 80 chars 5) Swap $RPM_BUILD_ROOT macro with %{buildroot} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review