Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=733572 Kalev Lember <kalevlember@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Kalev Lember <kalevlember@xxxxxxxxx> 2011-08-26 03:06:26 EDT --- (In reply to comment #3) > FYI, I already mailed upstream asking them to update the address in the > license headers but that isn't a blocker. Agreed; that's why I didn't mention it in the review in the first place. In my opinion rpmlint should make it a warning instead of an error. > Fixed the license tag and added the missing requires. Thanks. Excellent, looks good now. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review