Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=733572 Kalev Lember <kalevlember@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kalevlember@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kalevlember@xxxxxxxxx Flag| |fedora-review? --- Comment #2 from Kalev Lember <kalevlember@xxxxxxxxx> 2011-08-26 02:45:19 EDT --- Fedora review gnome-schedule-2.1.4-1.fc15.src.rpm 2011-08-26 + OK ! needs attention $ rpmlint /home/kalev/rpmbuild/SRPMS/gnome-schedule-2.1.4-1.fc16.src.rpm \ gnome-schedule gnome-schedule.src: W: spelling-error Summary(en_US) crontab -> contactable gnome-schedule.src: W: spelling-error %description -l en_US cron -> corn, con, crone gnome-schedule.src: W: spelling-error %description -l en_US crontab -> contactable gnome-schedule.noarch: W: spelling-error Summary(en_US) crontab -> contactable gnome-schedule.noarch: W: spelling-error %description -l en_US cron -> corn, con, crone gnome-schedule.noarch: W: spelling-error %description -l en_US crontab -> contactable gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/addWindow.py gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/mainWindow.py gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/at.py gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/lang.py gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/crontabEditorHelper.py gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/db.py gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/template_manager.py gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/gnome-schedule-import.py gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/gnome-schedule-export.py gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/template.py gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/data.py gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/setuserWindow.py gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/doc/gnome-schedule-2.1.4/COPYING gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/crontab.py gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/crontabEditor.py gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/atEditor.py gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/template_chooser.py gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/xwrapper.py gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/gnome-schedule.py gnome-schedule.noarch: E: incorrect-fsf-address /usr/share/gnome-schedule/config.py gnome-schedule.noarch: W: no-manual-page-for-binary gnome-schedule-export gnome-schedule.noarch: W: no-manual-page-for-binary gnome-schedule gnome-schedule.noarch: W: no-manual-page-for-binary gnome-schedule-import 2 packages and 0 specfiles checked; 20 errors, 9 warnings. + rpmlint warnings are harmless + The package is named according to Fedora packaging guidelines + The spec file name matches the package base name + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. ! The source files in the tarball appear to have GPLv2+ license headers (with the 'or any later version' clause) but the license tag in the spec file has GPLv2 (the v2-only version). + The package contains the license file (COPYING) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm. md5sum: af7d4912402be83c969d8d072d101ccc gnome-schedule-2.1.4.tar.gz af7d4912402be83c969d8d072d101ccc Download/gnome-schedule-2.1.4.tar.gz + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane + The spec file MUST handle locales properly n/a ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + No duplicated files in %files section + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel n/a Static libraries should be in -static n/a Library files that end in .so must go in a -devel package n/a -devel must require the fully versioned base n/a Packages should not contain libtool .la files + Packages containing GUI apps must include %{name}.desktop file + Directory ownership sane + Filenames are valid UTF-8 There package needs to depend on some additional python modules. I get the following when trying to run it on F16: > $ gnome-schedule > Traceback (most recent call last): > File "/usr/share/gnome-schedule/gnome-schedule.py", line 27, in <module> > import mainWindow > File "/usr/share/gnome-schedule/mainWindow.py", line 26, in <module> > import gnome > ImportError: No module named gnome Installing gnome-python2-gnome and gnome-python2-bonobo was enough to make it work. Please review the licensing (GPLv2 vs GPLv2+) and fix the missing deps on python modules and the package should be good to go in. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review