Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708765 --- Comment #80 from Mario Blättermann <mariobl@xxxxxxxxxx> 2011-08-25 14:01:19 EDT --- Many thanks for your review! (In reply to comment #78) > The Source0 URL is not good for the 0.6.1 release (check it out running > "spectool -g frogr.spec"), you'll need to hardcode 0.6 instead of %{version} to > fix it. > Yes, has been fixed. First I thought it would be fine to define a macro such as "%global baseversion 0.6", but I don't expect a lot of bugfix releases from the 0.6 branch. > Strictly speaking, since you install docs in /usr/share/gnome/help you should > either own that directory or require the packaging owning it (yelp), but I > found a thread in fedora-packaging where it seems it's ok to leave it this way. > > Ideally, frogr could be improved to print the error returned by the GNOME API > when yelp is not available. > A task for Mario Sanchez Prada (CC'ed anyway). But as far as I know, there should already be an error message if Yelp hasn't been found. > So, this package is APPROVED, but please be sure to fix the Source0 URL before > importing it. I will import this spec: Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/frogr.spec (In reply to comment #79) > A quick note: > %{_datadir}/%{name} is still unowned (see comment #19). I've removed the asterisk from the appropriate line in %files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review