Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pychess - Chess game for GNOME https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222569 peter@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From peter@xxxxxxxxxxxxxxxx 2007-01-14 16:37 EST ------- Thanks for the catch, Mamoru. However, this is behavior similar to my packaging of Scribes; and it was APPROVED with such changes. Seeing as how such permissions cause no apparent security issues or bugs with the software, I don't consider this a blocker. == Formal Review of pychess 0.6.0-0.2.beta5 == GOOD: rpmlint is silent on both the source and binary (noarch) RPMs. GOOD: The package follows the naming guidelines, and the spec file is named accordingly ("%{name}.spec"). GOOD: BuildRoot is "%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)", following the packaging guidelines. GOOD: No duplicate BuildRequires are included; and all necessary BuildRequires are listed. GOOD: Included documentation (%doc) is OK. GOOD: Package builds and runs against system copies of installed tools and libraries; and does not include its own local copies thereof. GOOD: Package includes an appropriate .desktop file since it is a graphical application; and desktop-file-install is properly used to install it. A BuildRequires: desktop-file-utils is also present. GOOD: Macros are used instead of harcoded file names, and usage of these macros (including $RPM_BUILD_ROOT) is consistent throughout the spec file. GOOD: Locale files are handled correctly, using %find_lang appropriately. GOOD: Package is not relocatable. GOOD: Package includes appropriate code and content; and final directory and file ownership is OK. GOOD: Package does not own any system files/directories or any files/directories that conflict with another package. GOOD: Package license (GPL) is OK; and a copy of it is included in the package as documentation (%doc LICENSE). The License field in the spec file properly reflects this. GOOD: Spec file is nicely legible. GOOD: The source tarball matches that of upstream: $ md5sum SOURCES/pychess-0.6.0-beta5* ed2cdca72465c4b529a1caf6960745be SOURCES/pychess-0.6.0_beta5-srpm.tar.gz ed2cdca72465c4b529a1caf6960745be SOURCES/pychess-0.6.0_beta5-upstream.tar.gz GOOD: The package successfully builds in mock into noarch binary RPMs on both FC6 and devel/FC7. GOOD: No duplicates are listed in the %files section; and its %defattr line is good. GOOD: Package has an appropriate %clean section, which contains simply "rm -rf $RPM_BUILD_ROOT" GOOD: When installed, the application runs well with no apparent segfaults or major bugs. N/A: No non-ASCII characters are needed, so encoding is OK. N/A: This is a noarch package, so compiler flags are not needed. N/A: No static libraries or rPath exclusions are needed. N/A: Package includes no configuration files or data, so %config markings are not needed. N/A: Package uses Python distutils for building; so using `make %{?_smp_flags}` is not needed. N/A: Package is not a web application. N/A: Package is noarch; thus no ExcludeArch/ExclusiveArch tweaking is required. N/A: Package installs no shared libraries; thus %post/%postun scriplets of /sbin/ldconfig are not needed. N/A: No large (neither in size nor in quantity) documentation is included, thus no -doc subpackage is needed. N/A: No headers, no pkgconfig files, and no static or unsuffixed shared libraries are included. Thus, no -devel subpackage is needed. N/A: Package contains no libtool archives (*.la files) N/A: Package contains no %description or Summary translations. N/A: Scriplets are not required for this package. I see only one thing that needs fixing with this package and that is that the %description contains what appear to be a lot of simple typos. The following would be more appropriate: "PyChess is a GTK+ chess game for Linux. It is designed to at the same time be easy to use, beautiful to look at, and provide advanced functions for advanced players." However, that is something you can fix after importing it into CVS. Therefore (under the condition that this is done), this package is APPROVED. Remember to also close this bug as NEXTRELEASE when it is imported and pushed through the build system. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review