Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710905 --- Comment #8 from Thomas Sailer <t.sailer@xxxxxxxxxxxxxx> 2011-08-24 12:46:50 EDT --- (In reply to comment #5) Thanks for taking the review! http://sailer.fedorapeople.org/octave-optim-1.0.16-2.fc15.src.rpm I've appled most of your suggestions, with the exception of the following: > looks *really* odd. Did you get an rpmlint warning about text in the wrong > encoding? I'm not a PostScript expert, but I'd leave these files as-is. You are right, it is wrong. But now I get the following lint warnings: octave-optim.x86_64: W: file-not-utf8 /usr/share/octave/packages/optim-1.0.16/doc/figures/2D_slice-3.eps2 octave-optim.x86_64: W: file-not-utf8 /usr/share/octave/packages/optim-1.0.16/doc/figures/optim_tutorial_slice.eps I think these warnings are bogus, they are coming from a binary portion of the eps file. > MUST: The License field in the package spec file must match the actual license. > NEEDSWORK Well, the DESCRIPTION file contained in the source archive lists GFDL as well as GPLv2+, so that's why it is listed in the RPM license field as well. > Please add a '-v' flag in the Makefile, so that the commands used in the build > are displayed. Sorry where do you want -v exactly? > And why are you using > > %octave_cmd pkg build '-verbose' '-nodeps' > %{_tmppath}/%{name}-%{version}-%{release}.%{_arch} %{_builddir}/%{buildsubdir} > > instead of > > %octave_pkg_build ? If I use octave_pkg_build, I get a build error: error: the following dependencies where unsatisfied: optim needs miscellaneous >= 1.0.11 optim needs struct >= 1.0.9 even though octave-miscellaneous and octave-struct are installed. Seems there is a problem with the dependency detection. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review