Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730888 James Laska <jlaska@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review?, |fedora-review+ |needinfo?(jlaska@xxxxxxxxxx | |) | --- Comment #5 from James Laska <jlaska@xxxxxxxxxx> 2011-08-24 09:04:11 EDT --- Greetings Douglas! Thanks for the quick turnaround on the suggested changes. I have re-reviewed the nagios-plugins-rhev package, and it passes my review. Feel free to request a new SCM branch according to the instructions at https://fedoraproject.org/wiki/Package_SCM_admin_requests. Feedback on resolved issues below. > [ WARN ] - In the upstream setup.py included in the tarball, there appears > to be a copy'n'paste error. The above issue has been resolved > > [ WARN ] MUST: All build dependencies must be listed in BuildRequires, except > > for any that are listed in the exceptions section of the Packaging > > Guidelines ; inclusion of those as BuildRequires is optional. Apply > > common sense. > > Should python-paramiko be listed as a Requires? It is imported from within > check_rhev. I assume this is a runtime requirement, not a build requirement? > Or perhaps both? The above issue has been resolved > [ FAIL ] MUST: A package must own all directories that it creates. If it does > not create a directory that it uses, then it should require a package > which does create that directory. The above issue has been resolved > [ OK ] MUST: The sources used to build the package must match the upstream > source, as provided in the spec URL. Reviewers should use md5sum for > this task. If no upstream URL can be specified for this package, > please see the Source URL Guidelines for how to deal with this. The above issue has been resolved $ md5sum nagios-plugins-rhev-1.0.0*tar* cb19d63804fca11c99996d354bae4d5a nagios-plugins-rhev-1.0.0.tar.gz cb19d63804fca11c99996d354bae4d5a nagios-plugins-rhev-1.0.0.tar.gz.upstream > [ WARN ] MUST: rpmlint must be run on every package The remaining warning regarding file-size-mismatch should not prevent this package from passing review. I have initiated discussion on packaging@ regarding this issue, and it seems related to using github for Source URL's (or the http server/configuration on github). To follow that discussion, refer to ... https://lists.fedoraproject.org/pipermail/packaging/2011-August/007912.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review