Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732758 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> 2011-08-24 08:00:36 EDT --- Source file is original. Ok. TODO: Change summary to wording used in POD: `TCP Transport Support for SOAP::Lite'. Current one just repeat Perl module name which is noting new from package name or list of files. Description verified from lib/SOAP/Transport/TCP.pm. Ok. FIX: Change license to `GPL+ or Artistic' as lib/SOAP/Transport/TCP.pm says: > This library is free software; you can redistribute it and/or modify it > under the same terms as Perl itself. No XS files, noarch architecture is Ok. Superfluous Net::FTP mentioned in META.yml is not needed (report it to upstream). Ok. Test::Pod, Test::Kwalitee, and Test::Pod::Coverage are non-default author's tests. They are not needed. Ok. FIX: BuildRequire (conditionally) perl(URI::_server) (lib/SOAP/Transport/TCP.pm:28) to proceed tests. Tests temporarily disabled for bootstrap. Ok. $ rpmlint perl-SOAP-Transport-TCP.spec ../SRPMS/perl-SOAP-Transport-TCP-0.715-1.fc15.src.rpm ../RPMS/noarch/perl-SOAP-Transport-TCP-0.715-1.fc15.noarch.rpm perl-SOAP-Transport-TCP.src: W: invalid-license Artistic perl-SOAP-Transport-TCP.noarch: W: invalid-license Artistic 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint (except the license) Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-SOAP-Transport-TCP-0.715-1.fc15.noarch.rpm drwxr-xr-x 2 root root 0 srp 24 13:38 /usr/share/doc/perl-SOAP-Transport-TCP-0.715 -rw-r--r-- 1 root root 51 srp 18 21:56 /usr/share/doc/perl-SOAP-Transport-TCP-0.715/Changes -rw-r--r-- 1 root root 291 srp 18 21:56 /usr/share/doc/perl-SOAP-Transport-TCP-0.715/README -rw-r--r-- 1 root root 3255 srp 24 13:38 /usr/share/man/man3/SOAP::Transport::TCP.3pm.gz drwxr-xr-x 2 root root 0 srp 24 13:38 /usr/share/perl5/vendor_perl/SOAP drwxr-xr-x 2 root root 0 srp 24 13:38 /usr/share/perl5/vendor_perl/SOAP/Transport -rw-r--r-- 1 root root 9657 srp 24 13:38 /usr/share/perl5/vendor_perl/SOAP/Transport/TCP.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-SOAP-Transport-TCP-0.715-1.fc15.noarch.rpm |sort |uniq -c 1 perl(Carp) 1 perl(IO::Select) 1 perl(IO::SessionData) 1 perl(IO::SessionSet) 1 perl(IO::Socket) 1 perl(:MODULE_COMPAT_5.12.4) 1 perl(SOAP::Lite) 1 perl(SOAP::Lite) >= 0.714 1 perl(strict) 1 perl(URI) 1 perl(URI::_server) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 TODO: Remove underspecified perl(SOAP::Lite) from Requires. $ rpm -q --provides -p ../RPMS/noarch/perl-SOAP-Transport-TCP-0.715-1.fc15.noarch.rpm |sort |uniq -c 1 perl(SOAP::Transport::TCP::Client) = 0.715 1 perl(SOAP::Transport::TCP::Server) = 0.715 1 perl(SOAP::Transport::TCP) = 0.715 1 perl-SOAP-Transport-TCP = 0.715-1.fc15 1 perl(URI::tcp) = 0.715 Binary provides Ok. Binary dependencies resolvable. Ok. Package builds in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3298031). ??? Otherwise package is in line Fedora and Perl packaging guidelines. Please correct all `FIX' prefixed issues, consider fixing `TODO' prefixed items and provide new spec file. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review