Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731898 Matt Domsch <matt_domsch@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #26 from Matt Domsch <matt_domsch@xxxxxxxx> 2011-08-23 15:54:43 EDT --- much improved. I see the current initscript patch still has: # chkconfig: - 41 59 (this is good) # description: OpenDKIM implements the DomainKeys Identified Mail (DKIM) # service and a milter-based filter application that can plug # in to any milter-aware MTA. # processname: opendkim # pidfile: /var/run/opendkim/opendkim.pid ### BEGIN INIT INFO # Provides: opendkim # Required-Start: opendkim # Required-Stop: opendkim # Default-Start: 2 3 4 5 # Default-Stop: 0 1 6 (this is wrong: delete default-start and -stop lines) Each of the subpackages needs a %doc that includes LICENSE and LICENSE.Sendmail. I know, it's annoying, but they can be installed separately. otherwise, rpmlint looks good now (I'm using Fedora 14 to build and run rpmlint). Everything else looks good. Sorry for the mess around libtool. What you've got now seems to be OK, no more rpaths either, yea! Fix these two, and I'll mark approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review