Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=731898 --- Comment #20 from Steve Jenkins <steve@xxxxxxxxxxxxxxxx> 2011-08-23 10:13:22 EDT --- (In reply to comment #19) > pkgconfig should be a BuildRequires, not a Requires. That's what I get for staying up late. :) Fixed. > http://fedoraproject.org/wiki/Packaging:UsersAndGroups notes need to > Requires(pre): shadow-utils also. Added. > This also notes that the user and group should not be removed on uninstall. > (see the %preun section) Removed from %preun. > I'll start the formal review next. Party on! :) New SRPM and spec: http://packages.stevejenkins.com/opendkim/2.4.2/working/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review