Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: blobby - Blobby Volley 2, a volley-ball game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222547 ------- Additional Comments From mr.ecik@xxxxxxxxx 2007-01-13 18:24 EST ------- REVIEW: * sources match upstream (md5: fdef3e59f0870d890be8dffaccd773ca) * package meets all guidelines it should * correct build root: %{_tmppath}/%{name}-%{version}-%{release}- root-%(%{__id_u} -n) * package is licensed under a GPL license and license text is included in package * the latest version is being packaged * no shared libraries * no duplicates in %files * %clean is present * proper scriptlets * no need to any subpackages * rpmlint is silent * final provides and requires are sane !* desktop file: Category Application is deprecated and should be removed. https://www.redhat.com/archives/fedora-extras-list/2006-October/msg00723.html * BRs listed good * mock builds fine (fc6/x86_64) * all directories are owned well !* a lack of Requires: you should add hicolor-icon-theme dependency: https://www.redhat.com/archives/fedora-extras-list/2006-September/msg00282.html THINGS to do: - get rid of an Application category - add hicolor-icon-theme dependency -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review