Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=726989 Steve Jenkins <steve@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |steve@xxxxxxxxxxxxxxxx --- Comment #3 from Steve Jenkins <steve@xxxxxxxxxxxxxxxx> 2011-08-21 11:20:30 EDT --- I'm also seeking a sponsor so I can't do an "official" review yet, but I'll give a little feedback. Passes rpmlint cleanly, and builds on my system. You may want to consider using the %{name} macro throughout the spec file, such as: %config(noreplace) /etc/%{name}.conf /bin/systemctl enable %{name}.service >/dev/null 2>&1 || : etc. I also ran it through Koji, here's the output for a dist-f15 target scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=3290059 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review