Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728701 Kalev Lember <kalevlember@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Kalev Lember <kalevlember@xxxxxxxxx> 2011-08-21 02:58:28 EDT --- Fedora review libalkimia-4.3.1-2.fc15.src.rpm 2011-08-21 + OK ! needs attention $ rpmlint libalkimia-4.3.1-2.fc16.src.rpm \ libalkimia-4.3.1-2.fc16.x86_64.rpm \ libalkimia-debuginfo-4.3.1-2.fc16.x86_64.rpm \ libalkimia-devel-4.3.1-2.fc16.x86_64.rpm libalkimia.x86_64: W: no-documentation libalkimia-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 2 warnings. + rpmlint warnings are harmless + The package is named according to Fedora packaging guidelines + The spec file name matches the package base name + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license n/a The package must contain license file if upstream tarball has one + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm. md5sum: 73d7f1365118019030b2045d95c92456 137323-libalkimia-4.3.1.tar.bz2 73d7f1365118019030b2045d95c92456 Download/137323-libalkimia-4.3.1.tar.bz2 + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane n/a The spec file MUST handle locales properly + ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + No duplicated files in %files section + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package + Header files should be in -devel n/a Static libraries should be in -static + Library files that end in .so must go in a -devel package + -devel must require the fully versioned base + Packages should not contain libtool .la files n/a Packages containing GUI apps must include %{name}.desktop file + Directory ownership sane + Filenames are valid UTF-8 Some small nits: - there's a trailing space on one of the lines in %check and some trailing newlines at the end of the file - I would advise to contact upstream and ask them to include a license file in the tarball - the 'rm -rf %{buildroot}' at the beginning of %install is no longer needed with recent rpmbuild These are all minor issues and not review blockers; feel free to address them as applicable before importing the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review