Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=732200 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #2 from Volker Fröhlich <volker27@xxxxxx> 2011-08-20 20:40:05 EDT --- Some quick comments: The package doesn't build for me in either mock or with rpmbuild. "This package contains a binary for the game." -- I think you can remove that from the description! Don't mix %{buildroot} and $RPM_BUILD_ROOT. Use -p when installing your sources. Remove " -n %{name}-%{version}". That is exactly the format it expects. You can remove the defattr. Don't put the summary in the first line of the spec file. You haven't defined the game_name macro. Rpmlint on the SRPM: berusky2.src: W: strange-permission berusky3d.ini 0600L [makerpm@fedora15 berusky2-0.3-1.fc14.src]$ desktop-file-validate berusky2.desktop berusky2.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated berusky2.desktop: error: (will be fatal in the future): value "berusky2.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path Ship NEWS, README, AUTHORS and COPYING as doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review