[Bug 731851] Review Request: pygobject3 - Parallel installable python module for GObject Introspection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=731851

Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(johnp@xxxxxxxxxx)

--- Comment #3 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> 2011-08-19 13:04:22 EDT ---
Some changes are necessary; please see the unchecked boxes:


#+TODO: TODO(t) WAIT(w@/!) FAIL(f@) | DONE(d) N/A(n)

* TODO Review [70%]
  - [X] Names [2/2]
    - [X] Package name
    - [X] Spec name
  - [X] Package version [2/2]
 http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Versioning
    - [X] Version number
   http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Version_Tag
    - [X] Release tag
   http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Release_Tag
  
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages
  - [X] Meets
[[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]]
  - [X] Source files match upstream
        $ sha1sum pygobject-2.90.2.tar.bz2
~/rpmbuild/SOURCES/pygobject-2.90.2.tar.bz2 
        ea56c46e2820578e18520d2ecd97547bbd8fc196  pygobject-2.90.2.tar.bz2
        ea56c46e2820578e18520d2ecd97547bbd8fc196 
/home/michel/rpmbuild/SOURCES/pygobject-2.90.2.tar.bz2
  - [X] [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries][No
bundled libraries]]
  - [-] License [2/4]
    - [X] License is Fedora-approved
    - [X] No licensing conflict
    - [ ] License field accurate
          some files are actually under MIT license; update field to say
          LGPLv2+ and MIT

          $ grep -rl "WITHOUT WARRANTY OF ANY KIND" *
          gi/pygi-property.c
          gi/pygi-foreign-gvariant.h
          gi/pygi-foreign-gvariant.c
          gi/pygi-foreign.c
          gi/pygi-signal-closure.h
          gi/pygi-foreign.h
          gi/pygi-property.h
          gi/pygi-foreign-cairo.c
          install-sh <-- irrelevant

    - [ ] License included iff packaged by upstream
          Please package COPYING file in pygobject3 and python3-gobject
  - [-] rpmlint [1/2]
    - [X] on src.rpm
          1 packages and 0 specfiles checked; 0 errors, 0 warnings.
    - [ ] on x86_64.rpm
          pygobject3.x86_64: W: incoherent-version-in-changelog 2.28.6-1
['2.90.2-1.fc16', '2.90.2-1']
          \=> version number needs updating
          pygobject3.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/gi/_gi_cairo.so _gi_cairo.so()(64bit)
          pygobject3.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/gi/_glib/_glib.so _glib.so()(64bit)
          pygobject3.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/gi/_gi.so _gi.so()(64bit)
          pygobject3.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/gi/_gobject/_gobject.so _gobject.so()(64bit)
          \=> normal for Python modules
          pygobject3.x86_64: E: library-without-ldconfig-postin
/usr/lib64/libpyglib-gi-2.0-python.so.0.0.0
          pygobject3.x86_64: E: library-without-ldconfig-postun
/usr/lib64/libpyglib-gi-2.0-python.so.0.0.0
          \=> ldconfig needs to be added
          pygobject3.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/libpyglib-gi-2.0-python.so
          \=> can this be moved to -devel?
          pygobject3.x86_64: W: doc-file-dependency
/usr/share/doc/pygobject3-2.90.2/examples/cairo-demo.py /usr/bin/env
          \=> harmless
          pygobject3-devel.x86_64: W: spelling-error Summary(en_US) embeding ->
embedding, bedimming, bedding
          \=> please correct spelling (wow, aspell actually works this time)
          pygobject3-devel.x86_64: W: no-documentation
          \=> harmless
          pygobject3-doc.x86_64: E: non-executable-script
/usr/share/pygobject/xsl/fixxref.py 0644L /usr/bin/env
          \=> is this even needed? might want to exclude it
          4 packages and 0 specfiles checked; 3 errors, 9 warnings.

  - [X] Language & locale [2/2]
    - [X] Spec in US English
    - [X] Spec legible
          field values could probably be better aligned, but that's a nitpick
  - [X] Build [2/2]
    - [X] BRs complete
    - [X] Directory ownership
  - [-] Spec inspection [7/10]
    - [ ] ldconfig for libraries
          Missing; see rpmlint comment
    - [X] No duplicate files
    - [X] File permissions
    - [X] Filenames must be UTF-8
    - [X] no BuildRoot
([[https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag][except if
targeting RHEL5]])
          OPTIONAL: buildroot could be removed
    - [X] [RHEL 5] %buildroot cleaned on %install
          OPTIONAL: rm -rf no longer necessary
    - [ ] Macro usage consistent
          Question: why is %{_smp_mflags} not used for building
python3-gobject?
    - [X] Documentation [2/2]
      - [X] If large docs, separate -doc
      - [X] %doc files are non-essential
    - [-] Development [3/4]
      - [X] Headers in -devel
      - [ ] If versioned .so's, unversioned in -devel
     see rpmlint comment above
      - [X] -devel, -static requires main
      - [X] No .la
    - [X] Other subpackages

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]