Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=698405 --- Comment #2 from Steve Traylen <steve.traylen@xxxxxxx> 2011-08-18 15:45:00 EDT --- 1) You have a few mentions of '/etc/init.d' which should be /etc/rc.d/init.d and in fact should be %{_initrddir}. You have to set this if you are targeting EPEL5 as well (yes please). 2) Given that mcollective and mcollective-client requires mcollective-common I see no need to duplicate the Requires: ruby Requires: rubygems Requires: rubygem-stomp on these packages. 3) Version 1.3.0 looks to be the newest version. 4) You have Requires: rubygem(stomp) and Requires: rubygem-stomp in some places. See ruby guidelines: 5) The ruby(abi) requires should be defined. http://fedoraproject.org/wiki/Packaging:Ruby 6) Notice how ruby_sitelib is defined here. http://fedoraproject.org/wiki/Packaging:Ruby -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review