Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: aqbanking - A library for online banking functions and financial data import/export https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222522 ------- Additional Comments From bugs.michael@xxxxxxx 2007-01-13 09:02 EST ------- Created an attachment (id=145526) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=145526&action=view) build failure log Not a full review, just an early bird's picks: * %defattr missing in several sub-packages * Obsoletes ought to specify max.versions (using "LT", or "LE" inequations) * main package must not own %{_libdir}/gwenhywfar since that belongs into the "gwenhywfar" pkg already * Excludes are not symmetric. That's dangerous since you can lose files: main package: %exclude %{_libdir}/aqbanking/plugins/*/debugger %exclude %{_libdir}/aqbanking/plugins/*/frontends/* %exclude %{_libdir}/aqbanking/plugins/*/wizards qbanking package: %{_libdir}/aqbanking/plugins/*/debugger %{_libdir}/aqbanking/plugins/*/frontends/qbanking %{_libdir}/aqbanking/plugins/*/wizards You exclude everything in %{_libdir}/aqbanking/plugins/*/frontends/* but only %{_libdir}/aqbanking/plugins/*/frontends/qbanking is included explicitly. Other content below %{_libdir}/aqbanking/plugins/*/frontends/ would be skipped/excluded silently. * the -devel packages ought to "Requires: automake", so the %{_datadir}/aclocal/ directory is not orphaned - and because smart applications use automake anyway - it's kinda difficult to determine the config values without using the foo-config scripts/pkgconfig/automake * [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT Useless check. Nowadays buildroot cannot be "/" anymore. * "Requires: pkgconfig" in the frontends' -devel packages is redundant, since they all need aqbanking-devel which in turn requires pkgconfig for all its *-config queries (due to the applied Patch2) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review