Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225645 Lukáš Nykrýn <lnykryn@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #4 from Lukáš Nykrýn <lnykryn@xxxxxxxxxx> 2011-08-17 05:53:22 EDT --- Checked git commit: a79564bb2bc60af43dde6748eafb23d853f80bde YES source files match upstream YES package meets naming and versioning guidelines. YES specfile is properly named, is cleanly written and uses macros consistently YES dist tag is present YES clean section and buildroot present YES license field matches the actual license YES license is open source-compatible YES License text included in package YES latest version is being packaged N/A BuildRequires are proper N/A compiler flags are appropriate YES package builds in mock (Rawhide/x86_64) N/A debuginfo package looks complete YES rpmlint is silent YES final provides and requires look sane -- dependence on perl is added automatically, but maybe it would by good to define it explicitly N/A %check is present and all tests pass N/A no shared libraries are added to the regular linker search paths YES owns the directories it creates YES doesn't own any directories it shouldn't YES no duplicates in %files N/A scriptlets must be sane YES code, not content N/A large documentation files must go in a -doc subpackage YES %docs are not necessary for the proper functioning of the package YES no headers YES no pkgconfig files YES no libtool .la droppings. YES not a GUI app. Additional comments: User news is not by default in system, so it use root, I don't know if it is desired behavior. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review