[Bug 730764] Review Request: wxpdfdoc - A library for creating PDF documents in C++ with wxWidgets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=730764

--- Comment #3 from Domingo Becker <domingobecker@xxxxxxxxx> 2011-08-16 12:32:00 EDT ---
(In reply to comment #2)
> I think better option to fix the libdir issue is to use sed which will fix it
> easily for all 64bit arches like s390x, ppc64, sparc64 and not only for x86_64
> 
> You could use
> sed -i.orig -e 's|$(prefix)/lib|$(prefix)/%{_lib}/|g' build/GNUmakefile
> instead of the %ifarch-ed %patch

Thank you, I will test it.

> 
> Another note - you should drop the gcc-c++ from BRs, it's always part of the
> buildroot, see http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2

But it's not always part of someone's own computer. And as I usually use
'rpmbuild --rebuild srpm-url', the package must have the gcc-c++ dependency in
order to succeed. I found this with my own packages.

Thank you, Dan.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]