Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=708554 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomspur@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2011-08-14 17:11:49 EDT --- Review: - afaik BR/R are ok (don't know perl, so can't be absolutely sure) - macros everywhere - arch ok - %build ok - %doc ok - rpmlint ok: $ rpmlint ~/rpmbuild/RPMS/noarch/umph-0.1.8-1.fc15.noarch.rpm ~/rpmbuild/SRPMS/umph-0.1.8-1.fc15.src.rpm umph.noarch: W: spelling-error %description -l en_US playlists -> play lists, play-lists, stylists umph.src: W: spelling-error %description -l en_US playlists -> play lists, play-lists, stylists umph.src: W: invalid-url Source0: http://umph.googlecode.com/files/umph-0.1.8.tar.gz HTTP Error 404: Not Found 2 packages and 0 specfiles checked; 0 errors, 3 warnings. All false positives, downloading with spectool worked. Is a correct url... Needswork: - License is wrong: it's not GPLv3 (=GPLv3 only), it's: GPLv3+ - same issue like with dependant package: compression of makefile could change, please use %{name}.1.* Please fix the 2 needswork and it's: ############################################################## APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review