[Bug 730426] Review Request: mindless - Find the secret code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=730426

Mario Blättermann <mariobl@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mariobl@xxxxxxxxxx

--- Comment #1 from Mario Blättermann <mariobl@xxxxxxxxxx> 2011-08-13 15:16:24 EDT ---
(In reply to comment #0)

> mindless.x86_64: E: incorrect-fsf-address /usr/share/doc/mindless-1.0.0/COPYING
> mindless.x86_64: W: no-manual-page-for-binary mindless
> 
> I've reported both to the developer, as expected.  (It remains to be seen if he
> cares enough about it.  This is a rather old program.)

For the COPYING file, you should fetch a new one from fsf.org [1] and replace
the old one. I assume the upstream developer is gone for a long time, given the
age of more than eight years. All the other occurences of the old address in
the source files you may leave untouched.

[1] http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt


If there's no man page available, no problem, it is no blocker for a package.

Some initial issues:

To make your spec better readable, you should put all macros into brackets {}.
The %defattr macro in the file list is obsolete, only for packages for older
EPEL versions needed. I assume you don't plan to provide it for EPEL, because
you didn't define a BuildRoot and there's no %clean section.

Your package ships the FreeSans font, which is already available for Fedora
(from the package gnu-free-sans-fonts). No idea what to do here, but in my
mind, although we don't have a file collision, a system doesn't need a font
twice.


Koji scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3270948

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]