Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724878 --- Comment #15 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-08-13 08:48:31 EDT --- OK, the package looks almost fine, but I think we need another iteration... However, it should be the last one. - Please remove "and %files -f %{name}.lang" from %find_lang. Sorry if my previous comment was misleading. The mentioned addition was supposed to show how the %files statement should look. - I get two messages from desktop-file-validate: $ desktop-file-validate texstudio.desktop texstudio.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated texstudio.desktop: error: (will be fatal in the future): value "texstudio.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path => drop the Encoding entry and the .png suffix from the .desktop file. The proper file extension is detected automatically. - Add %dir %{_datadir}/texstudio/ to %files for proper directory ownership. Some minor improvements: - Replace "Copying" with "COPYING" in the rm statement, and drop the %exclude from %files. - Also, add CHANGELOG.txt to the rm statement in %install, remove %{_datadir}/texstudio/CHANGELOG.txt in %files, and add it with %doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review