[Bug 693950] Review Request: yagf - Graphical front-end for cuneiform

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=693950

--- Comment #14 from Volker Fröhlich <volker27@xxxxxx> 2011-08-13 03:22:55 EDT ---
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache is the
wrong scriptlet to run, as you don't install files "into one of the
subdirectories in %{_datadir}/icons/ ..."

Please drop the version constraint for qt4-devel. There is no version that old
in Fedora.

Instead, your spec file meets the requirements for
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database

"Comment[pl]=Grafinė teksto atpažinimo programos Cuneiform sąsaja" -- That line
in the desktop file is wrong as well. Just delete it.

(line-break doesn't spell line-brake)
(You can cut out "on the Linux platform" from the description.)
(I also suggest to put each BuildRequirement on a separate line, as it is
easier to overlook.)

I guess we can do the formal review afterwards.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]