Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=724878 --- Comment #10 from hannes <johannes.lips@xxxxxxxxxxxxxx> 2011-08-12 13:58:22 EDT --- Ok thanks for the review! I asked upstream about the licensing [1] and the qt files [2]. So far I only received a reply for the qt_lang files and they are unmodified, so I removed them. The missing GPLv3 file is not a blocker or? Do I need to add one? Also I added the missing file_install macro but I am not sure if it's possible to use %exclude %{_datadir}/texstudio/texstudio_*.qm to exclude them in the file section. [1] http://sourceforge.net/tracker/?func=detail&aid=3390072&group_id=250595&atid=1126426 [2] http://sourceforge.net/projects/texstudio/forums/forum/907839/topic/4651681 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review