Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eclipse-changelog - simplifies the task of maintaining ChangeLogs for projects https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222365 ------- Additional Comments From overholt@xxxxxxxxxx 2007-01-12 13:07 EST ------- . Since this is Fedora, we can do away with the fedora and redhat defines. That can be simplified to just %define gcj_support 1 . replace %{eclipse_name} in the definition of eclipse_base to just be eclipse and remove eclipse_name entirely . please add a little explanation (or a script a la eclipse-emf and eclipse-gef ... in Extras) as to how the src zip is generated . "this plugins is really noarch but it" -> "These plugins are really noarch but they" . you've got an extra line between %prep and %build . it's also unfortunate that we have an epoch but we can't do anything about that now . do we require a specific version of the CDT? . how do we get around the optional python parser and a PyDev dependency? Otherwise, things look good! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review