Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: prewikka - Prelude IDS Management Console https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222070 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-01-12 12:11 EST ------- Well, * For file entry - Please clean up file entry. For example, why don't you just write ---------------------------------------------------- %{python_sitearch}/%{name}/ ---------------------------------------------------- instead of the directory + all files/directories under there? Just writing the directory without %dir prefix is interpretted as the directory and all files/directories under there. * Documentation install As said in comment 1, please don't use: ---------------------------------------------------- cp -p AUTHORS README NEWS HACKING.README \ %{buildroot}%{_defaultdocdir}/%{name}-%{version} cp -p doc/apache.conf %{buildroot}%{_defaultdocdir}/%{name}-%{version}/ cp README.fedora %{buildroot}%{_defaultdocdir}/%{name}-%{version} ---------------------------------------------------- Just write like: ---------------------------------------------------- %doc AUTHORS README NEWS HACKING.README doc/apache.conf ---------------------------------------------------- Using %doc without absolute path is interpretted as 1. to create the default documentation directory (%{_datadir}/doc/%{name}-%{version}) 2. Install the files/diretories listed into the directory. * README.fedora Don't create a patch. Just write README.fedora and include in srpm as a source. i.e. ---------------------------------------------------- ....... %Source0: <Please specify the URL> %Source1: README.fedora ........ %prep %setup -q cp -p %{SOURCE1} . ......... ......... %files ......... %doc AUTHORS ... %doc README.fedora ........... ---------------------------------------------------- * empty __init__.py This file is imported first when to call python modules in the directory, so this file is needed even this is empty. You can other empty __init__.py scripts in prewikka. And.. the existence of __init__.py means that the module scripts under this directory are imported from other binaries/scripts and not called directly by user. For this case the scripts should not have shebang and should not have executable permission flags. So: 1. Don't remove __init__.py under prewikka/templates/ 2. Set permission of all .py/.pyo/.pyc files under this directory as 0644 3. Remove shebang from all .py scripts under this directory. 4. And... check if prewikka works without problems if you do 1-3. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review