Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=729972 --- Comment #2 from Iain Arnell <iarnell@xxxxxxxxx> 2011-08-12 00:26:12 EDT --- A very nicely documented spec. No issues at all. APPROVED. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3267315 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): 96b654a0b0dd15c6ad327e4e59864bfd9c3c5af5 Test-Mojibake-0.3.tar.gz 96b654a0b0dd15c6ad327e4e59864bfd9c3c5af5 Test-Mojibake-0.3.tar.gz.srpm Final provides / requires are sane: ======> perl-Test-Mojibake-0.3-2.fc17.noarch.rpm <====== ====> rpmlint perl-Test-Mojibake.noarch: W: spelling-error %description -l en_US backend -> backed, back end, back-end perl-Test-Mojibake.noarch: W: spelling-error %description -l en_US encodings -> encoding, encoding s, recordings perl-Test-Mojibake.noarch: W: spelling-error %description -l en_US gedit -> edit, geddit, g edit perl-Test-Mojibake.noarch: E: incorrect-fsf-address /usr/share/doc/perl-Test-Mojibake-0.3/LICENSE 1 packages and 0 specfiles checked; 1 errors, 3 warnings. ====> provides perl(Test::Mojibake) = 0.3 perl-Test-Mojibake = 0.3-2.fc17 ====> requires perl >= 0:5.008 perl(bytes) perl(File::Spec) perl(:MODULE_COMPAT_5.14.1) perl(strict) perl(Test::Builder) perl(utf8) perl(warnings) ====> obsoletes ====> conflicts ======> perl-Test-Mojibake-0.3-2.fc17.src.rpm <====== ====> rpmlint perl-Test-Mojibake.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end perl-Test-Mojibake.src: W: spelling-error %description -l en_US encodings -> encoding, encoding s, recordings perl-Test-Mojibake.src: W: spelling-error %description -l en_US gedit -> edit, geddit, g edit perl-Test-Mojibake.src:66: W: mixed-use-of-spaces-and-tabs (spaces: line 66, tab: line 17) 1 packages and 0 specfiles checked; 0 errors, 4 warnings. ====> provides ====> requires perl(ExtUtils::MakeMaker) perl(File::Spec) perl(Pod::Coverage::TrustPod) perl(Test::Builder) perl(Test::Builder::Tester) perl(Test::CPAN::Changes) perl(Test::CPAN::Meta) perl(Test::DistManifest) perl(Test::HasVersion) perl(Test::Kwalitee) perl(Test::MinimumVersion) perl(Test::More) perl(Test::NoTabs) perl(Test::Perl::Critic) perl(Test::Pod) perl(Test::Pod::Coverage) perl(Test::Portability::Files) perl(Test::Synopsis) perl(Test::Vars) ====> obsoletes ====> conflicts ====> mock install INFO: mock.py version 1.1.12 starting... State Changed: init plugins INFO: selinux enabled State Changed: start Mock Version: 1.1.12 INFO: Mock Version: 1.1.12 State Changed: lock buildroot INFO: installing package(s): perl-Test-Mojibake-0.3-2.fc17.noarch.rpm INFO: Ignored option -c (probably due to merging -yc != -y -c) ================================================================================ Package Arch Version Repository Size ================================================================================ Installing: perl-Test-Mojibake noarch 0.3-2.fc17 /perl-Test-Mojibake-0.3-2.fc17.noarch 43 k Installing for dependencies: perl-CPAN noarch 1.9600-185.fc17 fedora 259 k perl-Digest-SHA x86_64 1:5.61-185.fc17 fedora 67 k perl-ExtUtils-MakeMaker noarch 6.57.5-185.fc17 fedora 303 k perl-ExtUtils-ParseXS noarch 1:2.2210-185.fc17 fedora 52 k perl-HTTP-Tiny noarch 0.012-185.fc17 fedora 40 k perl-Test-Harness noarch 3.23-185.fc17 fedora 287 k perl-Test-Simple noarch 0.98-185.fc17 fedora 118 k perl-devel x86_64 4:5.14.1-185.fc17 fedora 450 k python x86_64 2.7.2-4.fc16 fedora 74 k systemtap-sdt-devel x86_64 1.6-1.fc16 fedora 46 k Transaction Summary ================================================================================ Install 11 Package(s) Total size: 1.7 M Total download size: 1.7 M Installed size: 4.3 M Installed: perl-Test-Mojibake.noarch 0:0.3-2.fc17 Dependency Installed: perl-CPAN.noarch 0:1.9600-185.fc17 perl-Digest-SHA.x86_64 1:5.61-185.fc17 perl-ExtUtils-MakeMaker.noarch 0:6.57.5-185.fc17 perl-ExtUtils-ParseXS.noarch 1:2.2210-185.fc17 perl-HTTP-Tiny.noarch 0:0.012-185.fc17 perl-Test-Harness.noarch 0:3.23-185.fc17 perl-Test-Simple.noarch 0:0.98-185.fc17 perl-devel.x86_64 4:5.14.1-185.fc17 python.x86_64 0:2.7.2-4.fc16 systemtap-sdt-devel.x86_64 0:1.6-1.fc16 State Changed: unlock buildroot State Changed: end -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review