Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kio_sword - lightweight Sword front-end for KDE https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219873 ------- Additional Comments From fedora-packaging@xxxxxxxxxxxxxxxxxxxxx 2007-01-12 11:46 EST ------- Thanks, Deji. New files: Spec URL: http://david.dw-perspective.org.uk/tmp/kio_sword.spec SRPM URL: http://david.dw-perspective.org.uk/tmp/kio_sword-0.3-2.src.rpm > NEEDSWORK: > * Packages doesn't build in x86_64 mock Fixed using patch (thanks again!). > * Needs to call ldconfig in post and postun > * Packages must NOT contain any .la libtool archives I don't believe these two are true. All kioslaves need the libtool archive and won't work without them. Fedora ships these in kdebase for the standard kioslaves. (I believe that in KDE4 they'll go away). > * Ought to use the %find_lang for locales/translations There's no localisation upstream, so this is a no-op, but I've implemented it anyway (as I believe upstream is introducing it in future). > NITS: > * You should really require sword >=1.5.8 Done. > * Setting the CFLAGS in the spec is not necessary, it's already set by rpmbuild Removed. > * Also setting the $PATH for QT is not necesaary, already done /etc/profile.d/qt.sh Removed. > * I'm not sure what '--preserve-root' option does when you clean the buildroot, but I think its unnecesary. Paranoia - it tells "rm" to cancel the command if told to "rm -rf /" ! Anyway, gone now. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review