Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=722653 --- Comment #2 from Iain Arnell <iarnell@xxxxxxxxx> 2011-08-11 23:16:32 EDT --- A nice clean package. The only minor issue I have is with the summary - would prefer to see "Enable all of the features of Modern Perl with one command". APPROVED. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3267157 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): c564f6847d1433b03e10537cfa96145d28e367c0 Modern-Perl-1.03.tar.gz c564f6847d1433b03e10537cfa96145d28e367c0 Modern-Perl-1.03.tar.gz.srpm Final provides / requires are sane: ======> perl-Modern-Perl-1.03-1.fc17.noarch.rpm <====== ====> rpmlint perl-Modern-Perl.noarch: W: spelling-error %description -l en_US pragmas -> pragmatism 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ====> provides perl(Modern::Perl) = 1.03 perl-Modern-Perl = 1.03-1.fc17 ====> requires perl >= 1:5.010_000 perl(feature) perl(:MODULE_COMPAT_5.14.1) perl(mro) perl(strict) perl(warnings) ====> obsoletes ====> conflicts ======> perl-Modern-Perl-1.03-1.fc17.src.rpm <====== ====> rpmlint perl-Modern-Perl.src: W: spelling-error %description -l en_US pragmas -> pragmatism 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ====> provides ====> requires perl >= 0:5.10 perl(Module::Build) perl(Test::Simple) >= 0.8 ====> obsoletes ====> conflicts -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review