[Bug 729199] Review Request: satsolver - A new approach to package dependency solving

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=729199

--- Comment #5 from Miroslav Suchý <msuchy@xxxxxxxxxx> 2011-08-09 11:57:15 EDT ---
> rpmlint satsolver-0.17.2-1.fc15.src.rpm
> satsolver.src:101: W: macro-in-%changelog %3AFactory
> satsolver.src:101: W: macro-in-comment %3AFactory
You must double that percent char, even in that commend

> satsolver.src: W: invalid-url Source0: satsolver-0.17.2.tar.bz2
You have in spec:
 # download from https://github.com/openSUSE/sat-solver
 Source:         %{name}-%{version}.tar.bz2
This in not enough. That url offer you just download of HEAD of master branch.
And it may change every day or even every hour. You need something
reproducible. If upstream does not provide tar.gz you should use something
like:
 # downloaded from
https://github.com/openSUSE/sat-solver/commit/b9ef5a9a67d20d330c7b9f88c8a684d84a4166e2
 # which is tar.gz of commit b9ef5a9a67d20d330c7b9f88c8a684d84a4166e2 in master
branch
 Source:         %{name}-%{version}.tar.bz2

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]