Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=714328 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #11 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2011-08-09 11:34:33 EDT --- == Review == Here are the must fix items: * The xmedcon-config binary belongs in the -devel subpackage. * The -devel package must require the main subpackage with %{?_isa}: Requires: %{name}%{?_isa} = %{version}-%{release} https://fedoraproject.org/wiki/Packaging/Guidelines#Requires This prevents mismatch in multilib scenarios. * There must be a desktop file (and an icon) for xmedcon. https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files You might ask upstream for an icon, or use one of the generic icons for an image tool. Here are the optional fixes: * You're using %defattr(-,root,root,-) in %files sections, but this is now the default in all active Fedora branches. Consider removing it, although, this is not a blocker. == Details == - rpmlint checks return: xmedcon.src: W: spelling-error %description -l en_US Acr -> Ac, Ar, Apr xmedcon.src: W: spelling-error %description -l en_US uPET -> u Pet, PET, u PET xmedcon.x86_64: W: spelling-error %description -l en_US Acr -> Ac, Ar, Apr xmedcon.x86_64: W: spelling-error %description -l en_US uPET -> u Pet, PET, u PET xmedcon-devel.x86_64: W: spelling-error %description -l en_US libmdc -> libido All spelling errors safe to ignore. xmedcon.x86_64: W: shared-lib-calls-exit /usr/lib64/libmdc.so.2.0.1 exit@GLIBC_2.2.5 Safe to ignore. xmedcon.x86_64: W: devel-file-in-non-devel-package /usr/bin/xmedcon-config The xmedcon-config binary belongs in the -devel subpackage, this is a must-fix. xmedcon.x86_64: E: incorrect-fsf-address /usr/share/doc/xmedcon-0.10.7/COPYING.LIB xmedcon.x86_64: E: incorrect-fsf-address /usr/share/doc/xmedcon-0.10.7/COPYING xmedcon-devel.x86_64: E: incorrect-fsf-address /usr/share/doc/xmedcon-devel-0.10.7/COPYING.LIB xmedcon-devel.x86_64: E: incorrect-fsf-address /usr/share/doc/xmedcon-devel-0.10.7/COPYING Please inform the xmedcon upstream that they are using an outdated copy of the FSF license texts with the old FSF address, and ask them to please update this in their next release. - package meets naming guidelines - package meets packaging guidelines - license (LGPLv2+ and Copyright only and MIT and BSD and libtiff) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream: bc76d1edbe8e65bbea8afeca8a1d44a7d5e286a1befb5d42a743d1bfc6fe5016 - package compiles on devel (koji scratch OK) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - desktop file missing - devel package ok (except for misplaced xmedcon-config binary) - no .la files - post/postun ldconfig ok - devel requires base package n-v-r, but is missing %{_isa} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review