Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728737 Brendan Jones <brendan.jones.it@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Brendan Jones <brendan.jones.it@xxxxxxxxx> 2011-08-08 07:17:16 EDT --- Hi Orcan, this looks good to go. I did have trouble running the test included in the devel package, but I'll leave up that up to you to decide. Cheers, Brendan + OK - N/A ! Problem ? Not evaluated Required ======== [+] named according to the Package Naming Guidelines [+] The spec file name must match the base package %{name}, in the format %{name}.spec [+] Meet the Packaging Guidelines unless building for F12 and below or EPEL [+] Be licensed with a Fedora approved license and meet the Licensing Guidelines [+] The License field in the package spec file must match the actual license [+] License file must be included in %doc [+] The spec file must be written in American English [+] The spec file for the package MUST be legible [+] The sources used to build the package must match the upstream source [+] Successfully compile and build into binary rpms on at least one primary architecture [+] Proper use of ExcludeArch [+] All build dependencies must be listed in BuildRequires [+] The spec file MUST handle locales properly [+] Shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun [+] Packages must NOT bundle copies of system libraries [-] If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package [+] A package must own all directories that it creates directories under this [+] A Fedora package must not list a file more than once in the spec file's %files listings [+] Permissions on files must be set properly. Every %files section must include a %defattr(...) line [+] Each package must consistently use macros [+] The package must contain code, or permissable content [-] Large documentation files must go in a -doc subpackage [+] If a package includes something as %doc, it must not affect the runtime of the application [+] Header files must be in a -devel package [-] Static libraries must be in a -static package [+] library files that end in .so (without suffix) must go in a -devel package [+] devel packages must require the base package using a fully versioned dependency [+] Packages must NOT contain any .la libtool archives [-] GUI apps must include a %{name}.desktop file, properly installed with desktop-file-install in the %install section [+] Packages must not own files or directories already owned by other packages [+] All filenames in rpm packages must be valid UTF-8 Should Items ============ [+] the packager SHOULD query upstream for any missing license text files to include it [-] Non-English language support for description and summary sections in the package spec if available [+] The reviewer should test that the package builds in mock [+] The package should compile and build into binary rpms on all supported architectures [?] The reviewer should test that the package functions as described *** see below [+] If scriptlets are used, those scriptlets must be sane [-] Usually, subpackages other than devel should require the base package using a fully versioned dependency [+] The placement of pkgconfig(.pc) should usually be placed in a -devel pkg [-] If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself [-] Should contain man pages for binaries/scripts gcc -o /tmp/test_libinst /./usr/share/doc/libinstpatch-devel-1.0.0/create_sf2.c -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libinstpatch-1.0 -linstpatch-1.0 -lglib-2.0 -lgobject-2.0 ./test_libinst Synth_Stab_10.wav (process:18473): GLib-GObject-CRITICAL **: g_object_ref: assertion `object->ref_count > 0' failed (process:18473): GLib-GObject-CRITICAL **: g_object_unref: assertion `object->ref_count > 0' failed -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review