Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728664 --- Comment #1 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2011-08-07 14:02:52 EDT --- REVIEW: + OK - NA ? ISSUE + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum: git checkout, confirmed using diff. - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. + No rpmlint output. ^^ [ankur@ankur SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/*.rpm ../SPECS/django-pylibmc.spec django-pylibmc-0.2.1-1.20110806gitb56e74.fc15.src.rpm django-pylibmc.noarch: W: spelling-error Summary(en_US) backend -> backed, back end, back-end django-pylibmc.noarch: W: spelling-error %description -l en_US memcached -> schemed django-pylibmc.noarch: W: spelling-error %description -l en_US backend -> backed, back end, back-end django-pylibmc.src: W: spelling-error Summary(en_US) backend -> backed, back end, back-end django-pylibmc.src: W: spelling-error %description -l en_US memcached -> schemed django-pylibmc.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end django-pylibmc.src: W: invalid-url Source0: django-pylibmc-0.2.1.20110806gitb56e74.tar.xz ../SPECS/django-pylibmc.spec: W: invalid-url Source0: django-pylibmc-0.2.1.20110806gitb56e74.tar.xz django-pylibmc.src: W: spelling-error Summary(en_US) backend -> backed, back end, back-end django-pylibmc.src: W: spelling-error %description -l en_US memcached -> schemed django-pylibmc.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end django-pylibmc.src: W: invalid-url Source0: django-pylibmc-0.2.1.20110806gitb56e74.tar.xz 3 packages and 1 specfiles checked; 0 errors, 12 warnings. ONLY MINOR SPELLING SUGGESTIONS. OK + final provides and requires are sane: [ankur@ankur result]$ review-req-check == django-pylibmc-0.2.1-1.20110806gitb56e74.fc17.noarch.rpm == Provides: django-pylibmc = 0.2.1-1.20110806gitb56e74.fc17 Requires: python(abi) = 2.7 == django-pylibmc-0.2.1-1.20110806gitb56e74.fc17.src.rpm == Provides: Requires: python-devel python-setuptools python-pylibmc Django SHOULD Items: + Should build in mock. + Should build on all supported archs - Should function as described. - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version - check for outstanding bugs on package. (For core merge reviews) Issues: 1. Again, only a cosmetic suggestion for the setup macro directory name. Can be a simple %{name}. I'll approve this as soon as python-pylibmc is approved and built for rawhide. (It's *blocking* this one) Thanks, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review