Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728662 --- Comment #1 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2011-08-07 13:49:01 EDT --- Review: + OK - NA ? ISSUE + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum: ^^ Git check out, checked using diff. - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. + No rpmlint output. ^^ [ankur@ankur SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/*.rpm ../SPECS/python-pylibmc.spec python-pylibmc-1.2.0-1.20110805gitf01c31.fc15.src.rpm python-pylibmc.noarch: W: spelling-error Summary(en_US) Memcached -> Schemed python-pylibmc.noarch: W: spelling-error %description -l en_US memcached -> schemed python-pylibmc.noarch: W: spelling-error %description -l en_US libmemcached -> semidetached python-pylibmc.src: W: spelling-error Summary(en_US) Memcached -> Schemed python-pylibmc.src: W: spelling-error %description -l en_US memcached -> schemed python-pylibmc.src: W: spelling-error %description -l en_US libmemcached -> semidetached python-pylibmc.src: W: invalid-url Source0: python-pylibmc-1.2.0.20110805gitf01c31.tar.xz ../SPECS/python-pylibmc.spec: W: invalid-url Source0: python-pylibmc-1.2.0.20110805gitf01c31.tar.xz python-pylibmc.src: W: spelling-error Summary(en_US) Memcached -> Schemed python-pylibmc.src: W: spelling-error %description -l en_US memcached -> schemed python-pylibmc.src: W: spelling-error %description -l en_US libmemcached -> semidetached python-pylibmc.src: W: invalid-url Source0: python-pylibmc-1.2.0.20110805gitf01c31.tar.xz 3 packages and 1 specfiles checked; 0 errors, 12 warnings. MINOR SPELLING ERRORS ONLY. OK. + final provides and requires are sane: [ankur@ankur result]$ review-req-check == python-pylibmc-1.2.0-1.20110805gitf01c31.fc17.noarch.rpm == Provides: python-pylibmc = 1.2.0-1.20110805gitf01c31.fc17 Requires: python(abi) = 2.7 == python-pylibmc-1.2.0-1.20110805gitf01c31.fc17.src.rpm == Provides: Requires: python-devel python-setuptools libmemcached-devel zlib-devel SHOULD Items: + Should build in mock. + Should build on all supported archs - Should function as described. - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version - check for outstanding bugs on package. (For core merge reviews) Issues: 1. It looks like a good package. I see you've removed some sonames. Why is this? Please clarify and I shall approve the package :D Thanks, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review