[Bug 728737] Review Request: libinstpatch - MIDI instrument patch library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=728737

--- Comment #2 from Brendan Jones <brendan.jones.it@xxxxxxxxx> 2011-08-07 03:13:15 EDT ---
Hi Orcan,

The base package requirement in the subpackages needs to be in the format
"%{name}%{?_isa} = %{version}-%{release}"
(http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package).


Not a blocker but noted use of old FSF address. Most source headers are OK.

bsjones@f15laptop ~$rpmlint /home/rawhide/rpmbuild/SRPMS/libinstpatch*.rpm
libinstpatch.src: W: spelling-error %description -l en_US wavetable -> wave
table, wave-table, vegetable
libinstpatch.src: W: invalid-url Source0: libinstpatch-1.0.0-svn386.tar.bz2
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

bsjones@f15laptop ~$rpmlint
/home/rawhide/rpmbuild/RPMS/x86_64/libinstpatch*.rpm
libinstpatch.x86_64: W: spelling-error %description -l en_US wavetable -> wave
table, wave-table, vegetable
libinstpatch-devel.x86_64: E: incorrect-fsf-address
/usr/include/libinstpatch-1.0/libinstpatch/version.h
libinstpatch-devel.x86_64: E: incorrect-fsf-address
/usr/include/libinstpatch-1.0/libinstpatch/libinstpatch.h
3 packages and 0 specfiles checked; 2 errors, 1 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]