Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: polyester - KDE style and window decoration https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222220 ------- Additional Comments From josef@xxxxxxxxxxxxxx 2007-01-11 14:51 EST ------- ==== REVIEW CHECKLIST ==== * rpmlint output [josef@dhcp59-136 SPECS]$ rpmlint /home/josef/redhat/RPMS/x86_64/polyester-1.0-1.x86_64.rpm E: polyester binary-or-shlib-defines-rpath /usr/lib64/kde3/kstyle_polyester_config.so ['/usr/lib64'] E: polyester binary-or-shlib-defines-rpath /usr/lib64/kde3/kwin_polyester_config.so ['/usr/lib64'] E: polyester binary-or-shlib-defines-rpath /usr/lib64/kde3/kwin3_polyester.so ['/usr/lib64'] E: polyester binary-or-shlib-defines-rpath /usr/lib64/kde3/plugins/styles/polyester.so ['/usr/lib64'] - package meets package naming guidelines - spec filename matches %{name} - package meets packaging guidelines - package licensed with open source compatible license - license matches actual license - license file included in %doc - spec written in American english - spec file is legible - sources match upstream 12e5f0fa6daeb083621635b410d7c813 polyester-1.0.tar.bz2 - package successfully compiles and builds on x86_64 FC6 - all build dependencies listed in BR - locales handled properly - uses ldconfig properly - package is not relocatable - package owns all directories it creates - directories it does not create owned by default packages - no duplicates in %files - file permissions set properly - contains proper %clean section - macro usage consistent - package contains code - no large documentation - files in %doc do not affect runtime - no header files or static libraries - no pkgconfig files - no library files with suffix - no need for devel subpackage * contains .la files (should be OK http://fedoraproject.org/wiki/PackagingDrafts/LibtoolArchives) * desktop file is not installed via the appropriate methods - package does not own files or directories owned by other packages ====Things that need to be addressed==== * You need to fix the rpmlint errors. * You do not need the "Requires: kdebase", that should be pulled in automatically * You need to install the desktop file appropriatly, look here for an example http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755 gxine seems to install it by itself, so you will want to do something like what I did for geany http://www.toxicpanda.com/geany.spec I'm not sponsored, this is just a review to help me get sponsored. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review