[Bug 727909] Review Request: rubygem-capybara - Simplify the process of integration testing Rack applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=727909

--- Comment #2 from Chris Lalancette <clalance@xxxxxxxxxx> 2011-08-04 10:06:39 EDT ---
> Issues:
> [!] - license divergence needs to be clarified

Arg, yes, I forgot to change that.  I've fixed it now.

> 
> [!] : MUST - Rpmlint output is silent.

Yeah, that happens with all ruby packages, due to the way that rdoc builds
documentation files.  This can be ignored.

> 
> [!] - as with selenium-webdriver, there are divergences from the Ruby
> guidelines - could just be personal preference

%prep not being empty is due to the Fedora guidelines being out of date; the
unofficial way we have been doing pure ruby rubygems lately is to put
everything into %prep and %install.  If you think about it, that makes sense;
doing an "rpmbuild -bp <spec>" will then get you a tree that you can look at,
even if it is hidden beneath a directory tree.

I've uploaded a new version of the Spec and SRPM here:

http://people.redhat.com/clalance/rubygem-capybara/rubygem-capybara.spec
http://people.redhat.com/clalance/rubygem-capybara/rubygem-capybara-1.0.0-2.fc14.src.rpm

Can you take a look and approve if it looks good to you?  Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]