Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=727087 --- Comment #2 from Marcela Mašláňová <mmaslano@xxxxxxxxxx> 2011-08-04 09:20:00 EDT --- (In reply to comment #1) > Package: perl-Alien-SDL > Version: 1.428 > Release: 1.fc14 > Sources: Alien-SDL-1.428.tar.gz > Patches: > ---------- > NOTES: > ------ > rpmlint issues: > - incorrect FSF address; contact upstream about this They have broken bz, but hopefully, they will regenerate their package once. > - README file contains CRLF line endings; convert it to LF-only, please Fixed. > > requires: > Most of the explicitly specified runtime dependencies are automatically > picked by RPM, thus adding duplicates to the runtime dependencies list. > There's also an underspecified dependency you should filter out. > Please, remove perl(Capture::Tiny), perl(File::Spec), perl(File::Temp), and > perl(File::Which) (this one is not used at all) from Requires. > In addition, perl(File::Path) >= 2.08, perl(File::Fetch) >= 0.24, and > perl(Text::Patch) >= 1.4 should be required and their underspecified deps > filtered out... > Removed. > buildrequires: > perl(File::Spec::Functions) dependency is missing. Added. > Moreover, many of the listed build-time dependencies aren't used at all. > They're just mentioned in the META files (e.g. Archive::* stuff). But maybe > I'm just missing something. > They are in inc directory. > > Not approving at the moment. Please, approve now. http://mmaslano.fedorapeople.org/review/perl-Alien-SDL-1.428-1.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review