[Bug 226145] Merge Review: mkbootdisk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226145

Peter Schiffer <pschiffe@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Peter Schiffer <pschiffe@xxxxxxxxxx> 2011-08-04 09:04:00 EDT ---
Checked srpm:
$ sha256sum mkbootdisk-1.5.5-3.fc17.src.rpm 
09a64ea55c2ae301588ed836a55ac2fda3177e63c73f8d0c366ece786c3d156d
mkbootdisk-1.5.5-3.fc17.src.rpm

YES License text included in package.

NO rpmlint is silent - but all errors and warnings can be ignored.

$ rpmlint mkbootdisk.spec 
mkbootdisk.spec: W: no-%build-section
mkbootdisk.spec: W: invalid-url Source0: mkbootdisk-1.5.5.tar.xz
0 packages and 1 specfiles checked; 0 errors, 2 warnings.

$ rpmlint mkbootdisk-1.5.5-3.fc17.src.rpm 
mkbootdisk.src: W: spelling-error %description -l en_US filesystem -> file
system, file-system, systematic
mkbootdisk.src: W: spelling-error %description -l en_US fstab -> stab, f stab,
fiesta
mkbootdisk.src: W: spelling-error %description -l en_US ramdisk -> ram disk,
ram-disk, rammish
mkbootdisk.src: W: no-url-tag
mkbootdisk.src: W: no-%build-section
mkbootdisk.src: W: invalid-url Source0: mkbootdisk-1.5.5.tar.xz
1 packages and 0 specfiles checked; 0 errors, 6 warnings.

$ rpmlint mkbootdisk-1.5.5-3.fc17.x86_64.rpm 
mkbootdisk.x86_64: W: spelling-error %description -l en_US filesystem -> file
system, file-system, systematic
mkbootdisk.x86_64: W: spelling-error %description -l en_US fstab -> stab, f
stab, fiesta
mkbootdisk.x86_64: W: spelling-error %description -l en_US ramdisk -> ram disk,
ram-disk, rammish
mkbootdisk.x86_64: W: no-url-tag
mkbootdisk.x86_64: E: no-binary
1 packages and 0 specfiles checked; 1 errors, 4 warnings.

Additional comments:
 * rm -rf $RPM_BUILD_ROOT in %install section is not needed any more.

None of these comments is blocking the approval -> APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]