Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=721179 --- Comment #24 from Vít Ondruch <vondruch@xxxxxxxxxx> 2011-08-04 06:22:50 EDT --- (In reply to comment #23) > 2) The YARD documentation is generated in %check section. That is not correct > place. > > - FIXED, RSpec 2.x is generating yard doc automagically now. I don't understand it. The YARD doc is not generated at all, which is fine IMO, since nobody expect it to be generated. So now you can use BuildRequires: rubygem(rspec-core), ruby(json) and remove the Rake and Yard from BuildRequires. I would remove also the rakefile patch, since we are not using the rakefile, it is packaged in -doc subpackage and if somebody really wants to use it, (s)he should really know what is going on. Please also remove all the ruby_sitelib macro. It is not used anywhere and moreover rpmlint is complaining about the commented out version. If you fix/explain these issues, I will have no other objections. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review