Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=723575 --- Comment #3 from Patrick Monnerat <pm@xxxxxxxxxxxxx> 2011-08-03 09:36:53 EDT --- Thanks for the partial review. Here are the new links: SPEC: http://monnerat.fedorapeople.org/libpki.spec SRPMS: http://monnerat.fedorapeople.org/libpki-0.6.5-2.fc14.src.rpm Last changelog: * Fri Jul 22 2011 Patrick Monnerat <pm@xxxxxxxxxxxxx> 0.6.5-2 - Patch "pkgconfig" to fix pkg-config configuration file. - Sub-package "tools" for binary utilities. - libxml2-devel dependence added to devel sub-package. - "rpmbuild ... --without doc" is now recognized. rpmlint unchanged, except tools related messages issued by new tools sub-package instead of -devel. Thanks for the %bcond_without trick: I did not know it. %post and %postun scriptlets: WONTFIX. I agree with you it should be done this way, but this is an RPM problem. I tried "-p", but it does not work unless the next lines are empty until the next '%xxx' paragraph. I also tried %macros, but they are not substituted inside a scriptlet. Since the current solution works perfectly (though requiring /bin/sh which is always already present), I keep it unchanged to preserve my RPM comments: those improve a lot the readbility. RPM should provide a dummy "%endOfScript" paragraph or a comment escape scriptlet option to resolve this problem, but this is not the topic of this review request :-/ There are still upstream problems with this package (i.e.: soname): I'm in contact with the upstream project maintainer about them. Thanks again Michael for your work on it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review