Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=720857 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #4 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-08-03 02:29:47 EDT --- John, is this your first Fedora package submission? I can't find your email address in the packager group. If so, please add FE-NEEDSPONSOR to the Blocks field above and see the following pages for further information: http://fedoraproject.org/wiki/PackageMaintainers/Join http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Some quick comments on your spec: - According to the source file headers, the license is LGPLv2+. The "+" indicates the addition "or (at your option) any later version". - Drop the Vendor field. It is set automatically by the build system. - The BuildRoot field can be omitted for Fedora packages. However, it's still required for EPEL <= 5. If you keep it, use one of the variants given here: https://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag - Replace %defattr (-, root, root) with %defattr (-, root, root, -) or remove it completely. %defattr is still required for EPEL 4 builds, though. - Avoid using plain asterisks in %files. Always try to be more specific, especially if only single folders/files are added. - Add COPYING.LIB as %doc. The file containing the license text must always be packaged if present in the tarball. - Drop the asterisk from %{_datadir}/%{name}/* for proper directory ownership. - Fedora usually avoids providing static libraries. If there's no way to build a shared library for this package, see the following page how to handle the static one: https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries - Always bump the Release number if you provide a new package for the same version. Thus, two %changelog entries should never get the same %{version}-%{release} tag. Also, The %changlog is intended to document changes to the package/spec only. Therefore, don't add information about the (upstream) changes applied to the program code. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review